Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual decorate dial with fbopt #391

Merged
merged 30 commits into from
Nov 28, 2023
Merged

manual decorate dial with fbopt #391

merged 30 commits into from
Nov 28, 2023

Conversation

smilesun
Copy link
Collaborator

No description provided.

@smilesun smilesun added the priority Further information is requested label Sep 20, 2023
@smilesun smilesun self-assigned this Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (59e0ee0) 93.00% compared to head (9f73eab) 92.73%.

❗ Current head 9f73eab differs from pull request most recent head b2ef567. Consider uploading reports for the commit b2ef567 to get more accurate results

Files Patch % Lines
domainlab/algos/trainers/a_trainer.py 58.82% 7 Missing ⚠️
domainlab/algos/trainers/train_dial.py 25.00% 6 Missing ⚠️
domainlab/algos/builder_fbopt_dial.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            fbopt     #391      +/-   ##
==========================================
- Coverage   93.00%   92.73%   -0.28%     
==========================================
  Files         135      136       +1     
  Lines        5362     5396      +34     
==========================================
+ Hits         4987     5004      +17     
- Misses        375      392      +17     
Flag Coverage Δ
unittests 92.73% <55.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilesun
Copy link
Collaborator Author

RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn

@smilesun smilesun merged commit 69f761d into fbopt Nov 28, 2023
0 of 2 checks passed
@smilesun smilesun deleted the fbopt_dial branch November 28, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants