Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 #981

Merged
merged 3 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
fail-fast: false
matrix:
include:
- { name: "3.8", python: "3.8", tox: py38-marshmallow3 }
- { name: "3.9", python: "3.9", tox: py39-marshmallow3 }
- { name: "3.12", python: "3.12", tox: py312-marshmallow3 }
- { name: "lowest", python: "3.8", tox: py38-lowest }
- { name: "lowest", python: "3.9", tox: py39-lowest }
- { name: "dev", python: "3.12", tox: py312-marshmallowdev }
steps:
- uses: actions/checkout@v4.0.0
Expand Down
3 changes: 0 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ Install

pip install -U webargs

webargs supports Python >= 3.8.


Documentation
=============

Expand Down
2 changes: 1 addition & 1 deletion docs/install.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Install
=======

**webargs** requires Python >= 3.8. It depends on `marshmallow <https://marshmallow.readthedocs.io/en/latest/>`_ >= 3.0.0.
**webargs** depends on `marshmallow <https://marshmallow.readthedocs.io/en/latest/>`_ >= 3.0.0.

From the PyPI
-------------
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Natural Language :: English",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -40,7 +39,7 @@ keywords = [
"api",
"marshmallow",
]
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = ["marshmallow>=3.0.0", "packaging>=17.0"]

[project.urls]
Expand Down
6 changes: 3 additions & 3 deletions src/webargs/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
Request = typing.TypeVar("Request")
ArgMap = typing.Union[
ma.Schema,
typing.Type[ma.Schema],
typing.Mapping[str, typing.Union[ma.fields.Field, typing.Type[ma.fields.Field]]],
type[ma.Schema],
typing.Mapping[str, typing.Union[ma.fields.Field, type[ma.fields.Field]]],
typing.Callable[[Request], ma.Schema],
]

ValidateArg = typing.Union[None, typing.Callable, typing.Iterable[typing.Callable]]
CallableList = typing.List[typing.Callable]
CallableList = list[typing.Callable]
ErrorHandler = typing.Callable[..., typing.NoReturn]
# generic type var with no particular meaning
T = typing.TypeVar("T")
Expand Down
7 changes: 4 additions & 3 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ def test_load_json_called_by_parse_default(load_json, web_request):
"location", ["querystring", "form", "headers", "cookies", "files"]
)
def test_load_nondefault_called_by_parse_with_location(location, web_request):
with mock.patch(
f"webargs.core.Parser.load_{location}"
) as mock_loadfunc, mock.patch("webargs.core.Parser.load_json") as load_json:
with (
mock.patch(f"webargs.core.Parser.load_{location}") as mock_loadfunc,
mock.patch("webargs.core.Parser.load_json") as load_json,
):
mock_loadfunc.return_value = {}
load_json.return_value = {}
p = Parser()
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[tox]
envlist=
lint
py{38,39,310,311,312}-marshmallow3
py{39,310,311,312}-marshmallow3
py312-marshmallowdev
py38-lowest
py39-lowest
docs

[testenv]
Expand Down