fix: collapse container height when appearance set to interaction-only #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marsidev
approved these changes
Feb 16, 2024
|
Thank you! @jinsley8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
appearanceis set tointeraction-only, the container's height is set toheight: '0px', yet it occupies 24px of height, visible as empty space, even though the children div also haveheight: 0px.This fix addresses the issue by adding
display: flexto the container height forappearance: interaction-only. This change collapses the parent container height if the children have no height.Changes Made
display: flexto the container height forappearance: interaction-only.Visual Comparison
Additional Notes
size.