Implement update_or_create method
#337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellmetha
reviewed
Feb 7, 2026
| ) | ||
| record = get!(Node.new(**kwargs)) | ||
| record.set_field_values(updates) | ||
| record.save(using: @query.using) |
Member
There was a problem hiding this comment.
I guess it could be interesting to have an #update_or_create! variant of the method where we call #save! so that an exception is raised if the created/updated record is invalid.
| record.save(using: @query.using) | ||
| record | ||
| rescue Errors::RecordNotFound | ||
| update_attributes = defaults.nil? ? updates : defaults.not_nil! |
Member
There was a problem hiding this comment.
Shouldn't we be using both the updates AND defaults values here if defaults is set? Technically, the method should create new records with defaults if they do not exist yet, but all the records should end up having the updates values after the method is called (regardless of whether they got created/updated).
Suggested change
| update_attributes = defaults.nil? ? updates : defaults.not_nil! | |
| update_attributes = defaults.nil? ? updates : defaults.not_nil!.merge(updates) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
#update_or_createmethod to the querysets.With this newly added method a developer can update specific fields, defined by
updates, of record that matches the filter or, if no record can be found, create a new record. The new record will either created by theupdatesarguments or a customdefaultshash can be used if creation requires certain fields to be setCloses #308