Merge SpenceKonde's generalisation to more cores #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, I can't really test the code on hardware but the code looks good. Just wondering what the pre-release state of the AtTinyCore 2.0 means for this PR -> If someone tries to use it with the previous version, does it provide sensible error messages? |
Author
|
I'm busy wrapping up my current project, but should be able to test this out 1st weekend of July. Also, I found a bug yesterday that I must have introduced by something I did to create this PR (it's not present when using Spence's code as-is). Would it be alright to just leave it open a few more weeks? |
Owner
|
sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @martin2250, hi @SpenceKonde. I don't know why this work was never suggested as a PR here. Since Spence's repository doesn't have Issues, I'll try to raise the question in a PR myself here. I'm using this code on an ATtiny414 together with megaTinyCore and it's working like a charm.
Spence's repository is mentioned in #11 and I believe they were prompted to creating it by an Issue on megaTinyCore, here SpenceKonde/megaTinyCore#395.