-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numpy version 2.0.2 #254
Conversation
Reviewer's Guide by SourceryThis pull request updates the numpy version to 2.0.2 and temporarily drops support for TensorFlow due to compatibility issues. The changes involve updating dependencies, modifying test files, and adjusting import statements across multiple files. Sequence diagram for test execution with TensorFlow skippedsequenceDiagram
actor Tester
participant TestSuite
participant PyTest
Tester->>TestSuite: Run tests
TestSuite->>PyTest: Execute test_rgb_image_hand_fitting_tensorflow
PyTest-->>TestSuite: Skip test (reason: TensorFlow does not support numpy 2.0)
TestSuite-->>Tester: Test skipped
Architecture diagram for updated virtual environment setupgraph TD;
A[create_venv.bat] -->|Activates| B[python_venv/Scripts/activate.bat];
B -->|Installs| C[pip install uv];
C -->|Synchronizes| D[uv pip sync requirements.txt];
D -->|Installs| E[uv pip install -e .];
Class diagram for TensorFlow support removalclassDiagram
class MeshRGBFitterWithPose {
<<interface>>
}
class PyTorchMeshRGBFitterWithPose {
<<interface>>
}
class TensorflowTorchMeshRGBFitterWithPose {
<<interface>>
note "Commented out due to TensorFlow support removal"
}
class MeshDepthFitter {
<<interface>>
}
class PytorchMeshDepthFitter {
<<interface>>
}
class TensorFlowMeshDepthFitter {
<<interface>>
note "Commented out due to TensorFlow support removal"
}
class CameraTensorflow {
<<class>>
+CameraTensorflow()
note "Raises NotImplementedError due to TensorFlow support removal"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martinResearch - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Update numpy version 2.0.2, and dropping support for tensorflow for now as the tensorflow-intel package does not support numpy>=2 yet
Summary by Sourcery
Update numpy to version 2.0.2 and drop support for TensorFlow due to incompatibility issues. Modify the virtual environment setup script to use 'uv' for package management and skip TensorFlow-related tests.
Build:
Tests:
Chores: