Skip to content

Commit

Permalink
Bazel arguments which apply globally should use the common group
Browse files Browse the repository at this point in the history
  • Loading branch information
martis42 committed Jan 3, 2024
1 parent 9b7f5c4 commit 5e653cb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ test --test_output=errors
# yanking a module). Furthermore, the module resolution is deterministic.
# However, there are several open issues suggesting the lock file will change in one way or another.
# Thus, we don't use the bzlmod locking yet.
build --lockfile_mode=off
common --lockfile_mode=off

# When working with hermetic Python toolchains, supporting the legacy runfiles layout is needlessly wasting resources.
# See https://github.com/bazelbuild/rules_python/issues/1653
build --nolegacy_external_runfiles
common --nolegacy_external_runfiles

# Mypy integration
build:mypy --aspects=@mypy_integration//:mypy.bzl%mypy_aspect
Expand Down
6 changes: 3 additions & 3 deletions examples/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# When working with hermetic Python toolchains, supporting the legacy runfiles layout is needlessly wasting resources.
# See https://github.com/bazelbuild/rules_python/issues/1653
build --nolegacy_external_runfiles
common --nolegacy_external_runfiles

# The symlinks are annoying
build --experimental_convenience_symlinks=clean
common --experimental_convenience_symlinks=clean

# The performance gains offered by the lockfile are minimal for us.
# Pinning the dependencies should be superfluous from a reproducibility perspective as the central registry is supposed
# to be immutable for a module X in version Y after it has ben registered with the registry (ignoring the possibility of
# yanking a module). Furthermore, the module resolution is deterministic.
# However, there are several open issues suggesting the lock file will change in one way or another.
# Thus, we don't use the bzlmod locking yet.
build --lockfile_mode=off
common --lockfile_mode=off

0 comments on commit 5e653cb

Please sign in to comment.