Test examples with both workspace modi #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to provide targets from the root workspace to DWYU explicitly with labels as auto generating labels from strings does not work with bzlmod. With bzlmod the strings are converted in the wrong context to a label and thus cause visibility errors.
Python 3.8 is the minimum version to which we promise compatibility. Our tests should ensure this promise holds.
martis42
force-pushed
the
test_examples_with_both_workspace_modi
branch
from
330cb99 to
02d134b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to provide targets from the root workspace to DWYU explicitly with labels as auto generating labels from strings does not work with bzlmod. With bzlmod the strings are converted in the wrong context to a label and thus cause visibility errors.