Work around missing "stringListValue" in certain cases #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martis42
requested changes
Aug 10, 2024
| @@ -47,7 +47,7 @@ def get_dependencies(bazel_query: BazelQuery, target: str) -> list[Dependency]: | |||
| for x in queried_targets: | |||
| if x["type"] == "RULE" and x["rule"]["ruleClass"].startswith("cc_"): | |||
| for attr in x["rule"]["attribute"]: | |||
| if attr["name"] == "hdrs" and attr["explicitlySpecified"]: | |||
| if attr["name"] == "hdrs" and attr["explicitlySpecified"] and "stringListValue" in attrs: | |||
There was a problem hiding this comment.
@mrkkrp thanks for this contribution
- I believe there is a typo. It should be
.. in attr: - Can you provide an example where this fails? Your change makes either way sense as defensive programming. Still, I am curious as the only
cc_rules with thehdrsattribute arecc_libraryandcc_import. With those I can't reproduce this.
There was a problem hiding this comment.
Good catch! I applied the fix. The issue seems to be triggered when you have a cc_library that does not have any headers of its own but nevertheless specifies hdrs = [] explicitly.
It seems that not all targets that explicitly specify the `hdrs` attribute also have the `stringListValue` present.
mrkkrp
force-pushed
the
no-string-list-value
branch
from
413de2e to
d554be9
Compare
martis42
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that not all targets that explicitly specify the
hdrsattribute also have thestringListValuepresent.