[eem] fix builtin definition metrics (elastic#189065)

Closes elastic#188769 Closes elastic#188765 Fixes the throughput and failedTransactionRate that were not correctly computed
maryam-saeidi · Jul 25, 2024 · 76237d8 · 76237d8
1 parent 67b8d98
commit 76237d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/x-pack/packages/kbn-entities-schema/src/schema/common.ts b/x-pack/packages/kbn-entities-schema/src/schema/common.ts
@@ -15,6 +15,7 @@ export enum BasicAggregations {
   max = 'max',
   min = 'min',
   sum = 'sum',
+  value_count = 'value_count',
   cardinality = 'cardinality',
   last_value = 'last_value',
   std_deviation = 'std_deviation',

diff --git a/...ck/plugins/observability_solution/entity_manager/server/lib/entities/built_in/services.ts b/...ck/plugins/observability_solution/entity_manager/server/lib/entities/built_in/services.ts
@@ -76,24 +76,27 @@ export const builtInServicesFromLogsEntityDefinition: EntityDefinition =
         metrics: [
           {
             name: 'A',
-            aggregation: 'doc_count',
+            aggregation: 'value_count',
             filter: serviceTransactionFilter(),
+            field: 'transaction.duration.summary',
           },
         ],
       },
       {
         name: 'failedTransactionRate',
-        equation: 'A / B',
+        equation: '1 - (A / B)',
         metrics: [
           {
             name: 'A',
-            aggregation: 'doc_count',
-            filter: serviceTransactionFilter(['event.outcome: "failure"']),
+            aggregation: 'sum',
+            filter: serviceTransactionFilter(),
+            field: 'event.success_count',
           },
           {
             name: 'B',
-            aggregation: 'doc_count',
-            filter: serviceTransactionFilter(['event.outcome: *']),
+            aggregation: 'value_count',
+            filter: serviceTransactionFilter(),
+            field: 'event.success_count',
           },
         ],
       },