forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fleet] Show in UI warning which data streams require root (elastic#1…
…84119) ## Summary Closes elastic/ingest-dev#3357 Updated UI warning to show which data streams require root, if not all. To verify: - enroll an unprivileged agent to an agent policy (e.g. using docker) - add system integration to the agent policy - when clicking `Save and continue`, verify that the modal shows a callout saying which data streams require root <img width="853" alt="image" src="https://github.com/elastic/kibana/assets/90178898/db8bf26e-de46-4eeb-a471-002021fff3bc"> Updated the Add agent flyout condition as well to show those packages that has data streams that require root: To verify: - create an agent policy with system integration - open `Add agent` flyout - verify that the warning callout mentions `System` integration requiring root <img width="819" alt="image" src="https://github.com/elastic/kibana/assets/90178898/abb7e620-f9e4-4662-b0e8-9a16448e52bb"> Open question: - Do we want to show data stream names that require root on Add agent flyout too? It is possible but increases the complexity to store data stream names in package policy SO and populate in API. At this point I think it's enough to show the list of integrations there. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
1 parent
23446f2
commit b86039e
Showing
8 changed files
with
173 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
x-pack/test/fleet_api_integration/apis/agent_policy/__snapshots__/agent_policy.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.