Expand ScanRange checks with returning false if keyBeforeStart or key…

…OutOfRange with empty arrays.
marykdb · Feb 24, 2025 · 5c2f302 · 5c2f302
1 parent 11a1325
commit 5c2f302
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/core/src/commonMain/kotlin/maryk/core/processors/datastore/scanRange/ScanRange.kt b/core/src/commonMain/kotlin/maryk/core/processors/datastore/scanRange/ScanRange.kt
@@ -16,14 +16,22 @@ data class ScanRange internal constructor(
 ) {
     /** Checks if [key] is before start of this scan range */
     fun keyBeforeStart(key: ByteArray, offset: Int = 0, length: Int = key.size - offset) =
-        start.compareDefinedTo(key, offset, length).let {
-            if (startInclusive) it > 0 else it >= 0
+        if (start.isEmpty()) {
+            false
+        } else {
+            start.compareDefinedTo(key, offset, length).let {
+                if (startInclusive) it > 0 else it >= 0
+            }
         }
 
-    /** Checks if [key] is after the end of this range start of this scan range */
+    /** Checks if [key] is after the end of this range end of this scan range */
     fun keyOutOfRange(key: ByteArray, offset: Int = 0, length: Int = key.size - offset) = end?.let {
-        end.compareDefinedTo(key, offset, length).let {
-            if (endInclusive) it < 0 else it <= 0
+        if (end.isEmpty()) {
+            false
+        } else {
+            end.compareDefinedTo(key, offset, length).let {
+                if (endInclusive) it < 0 else it <= 0
+            }
         }
     } == true