Reuse Reference in readStorageTo calls for select in HBase

marykdb · Feb 12, 2024 · da519cf · da519cf
1 parent f5a155e
commit da519cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/core/src/commonMain/kotlin/maryk/core/processors/datastore/readStorageToChanges.kt b/core/src/commonMain/kotlin/maryk/core/processors/datastore/readStorageToChanges.kt
@@ -221,7 +221,9 @@ private fun <DM : IsDataModel> DM.readQualifier(
                 val definition = this[index]
                     ?: throw DefNotFoundException("No definition for $index in $this at $index")
 
-                if (select?.contains(definition.ref(parentReference)) == false) {
+                val ref = definition.ref(parentReference)
+
+                if (select?.contains(ref) == false) {
                     null // Skip since not in select
                 } else {
                     readQualifierOfType(
@@ -232,7 +234,7 @@ private fun <DM : IsDataModel> DM.readQualifier(
                         refStoreType,
                         index,
                         select,
-                        definition.ref(parentReference),
+                        ref,
                         addChangeToOutput,
                         readValueFromStorage,
                         addToCache

diff --git a/core/src/commonMain/kotlin/maryk/core/processors/datastore/readStorageToValues.kt b/core/src/commonMain/kotlin/maryk/core/processors/datastore/readStorageToValues.kt
@@ -114,7 +114,9 @@ private fun <DM : IsValuesDataModel> DM.readQualifier(
                 val definition = this[index]
                     ?: throw DefNotFoundException("No definition for $index in $this at $index")
 
-                if (select?.contains(definition.ref(parentReference)) == false) {
+                val ref = definition.ref(parentReference)
+
+                if (select?.contains(ref) == false) {
                     null // Skip since not in select
                 } else {
                     readQualifierOfType(
@@ -126,7 +128,7 @@ private fun <DM : IsValuesDataModel> DM.readQualifier(
                         index,
                         refStoreType,
                         select,
-                        definition.ref(parentReference),
+                        ref,
                         addValueToOutput,
                         readValueFromStorage,
                         addToCache