Refactor/env #15
Merged
Refactor/env #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 서버에서 실행할 때, (staging, production)에는 env파일에서 로딩하지 않도록 수정
환경에 따라 서버에서 실행되는 경우 ignoreEnvFile==true 가 되도록 설정
Ho-s
reviewed
Jun 27, 2024
| @@ -13,16 +13,16 @@ const stage = 'stage'; | |||
| const production = 'production'; | |||
| const test = 'test'; | |||
There was a problem hiding this comment.
갑자기 생각난 건데, 여기 const들 재사용 안되니까,
export type ArrayElement<T extends readonly unknown[]> = T extends readonly (infer K)[] ? K : never;
const array = ['development', 'stage', 'production', 'test'] as const;
type ArrayType = ArrayElement<typeof array>;
const NODE_ENVIRONMENT = array.reduce(
(acc, cur) => {
acc[cur] = cur;
return acc;
},
{} as Record<ArrayType, ArrayType>,
);이런식으로 가는 거 어떨까요?
There was a problem hiding this comment.
올려준 방식은 아니지만 NODE_ENV한번만 로드해서 사용할 수 있도록 수정했습니당
NODE_ENV를 한번만 로드하고 사용할 수 있도록 수정 - 중복 코드 제거 Refactor: refactor get NODE_ENV Refactor: refactor get NODE_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
서버에서 실행되는 경우 env file을 로드하지 않도록 수정
Key changes
To reviewers
ignoreEnvFile 관련 문서