Feat/change sign in logic 카카오 로그인 로직을 바꿨어요 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat: Add cache in config module to increase performance * Feat: Add environment validation - Install joi - Create validate function
- Add intermidiate table name user-map
- Install kakao passport - Add token column in user entity - Add kakao client id in .env
sally0226
reviewed
Jun 29, 2024
| provider: UserProvider.KAKAO, | ||
| providerId, | ||
| providerId: id.toString(), |
There was a problem hiding this comment.
카카오의 user id를 의미하는거면 providerUserId나 kakaoUserId로 네이밍하는건 어떨까용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
카카오 로그인 로직 변경
Key changes
To reviewers
Screenshots