스케줄 주소 키값 변경 대응 #305
Merged
스케줄 주소 키값 변경 대응 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main Release/1.8.1
✅ Deploy Preview for affectionate-jones-aa31c6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HaJunRyu
approved these changes
Jun 1, 2024
| location.roadAddress === null | ||
| ? location.detailAddress // ZOOM | ||
| : `${location.roadAddress}${ | ||
| location.detailAddress ? `, ${location.detailAddress}` : '' |
There was a problem hiding this comment.
사소하긴한데 삼항연산자 중첩이라 약간 가독성 안좋은 느낌도 있는거 같아서 return 구문 전에 detailAddress 같은 변수명으로 삼항 연사자 한번 처리하고 여기선 값만 주입하면 좋을거 같다는 생각~! 근데 취향이라 공감 안되면 그냥 넘어가도 되고ㅎㅎ
sanoopark
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
placeName이 없는 경우에 대응하기 위한 서버 키값 변경 및 각 키의 용도 변경에 대한 대응
작업 유형
체크리스트