Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

헬퍼 생성 시 문자열 변환 로직 이슈 해결 #317

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Baek2back
Copy link
Member

@Baek2back Baek2back commented Jan 15, 2025

변경사항

  • iOS, Web, Android ... 형태의 문자열에 대해 String.prototype.toLocaleUpperCase()를 적용한 결과를 "${platform}_ HELPER"로 변환 후 요청에 전달하면서, 서버 에러가 발생하여 iOS 팀에 대해서만 원본 문자열을 그대로 전달하도록 대응합니다.

작업 유형

  • 버그 수정

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@Baek2back Baek2back self-assigned this Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for affectionate-jones-aa31c6 ready!

Name Link
🔨 Latest commit 851975b
🔍 Latest deploy log https://app.netlify.com/sites/affectionate-jones-aa31c6/deploys/678715eeaec4fd0008aa19a1
😎 Deploy Preview https://deploy-preview-317--affectionate-jones-aa31c6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Baek2back Baek2back merged commit a885fd8 into develop Jan 15, 2025
4 of 5 checks passed
@Baek2back Baek2back deleted the feature/helper-create-modal branch January 15, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant