Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] 로딩시 클릭되는 이슈 수정 #238

Merged
merged 2 commits into from
Sep 21, 2024
Merged

[QA] 로딩시 클릭되는 이슈 수정 #238

merged 2 commits into from
Sep 21, 2024

Conversation

hj1115hj
Copy link
Collaborator

@hj1115hj hj1115hj commented Sep 19, 2024 •
edited
Loading

Issue

작업 내역 (Required)

  • click 버튼 로딩중에 클릭되지 않도록 수정
  • 스켈레톤 shap 적용

Review Point (Required)

Screenshot

Before After

관련 링크

@hj1115hj hj1115hj self-assigned this Sep 19, 2024
EvergreenTree97
EvergreenTree97 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@EvergreenTree97 EvergreenTree97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~

ze-zeh
ze-zeh approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@ze-zeh ze-zeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구우우우욷

feature/detail/src/main/java/team/ppac/detail/component/DetailContent.kt
onClickFunnyButton = onClickFunnyButton,
onReactionButtonPositioned = onReactionButtonPositioned
onReactionButtonPositioned = onReactionButtonPositioned,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, << 편-안

@hj1115hj hj1115hj merged commit e093cd5 into develop Sep 21, 2024
1 check passed
@hj1115hj hj1115hj deleted the qa/detail_skeleton branch September 21, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvergreenTree97 EvergreenTree97 EvergreenTree97 approved these changes

@ze-zeh ze-zeh ze-zeh approved these changes

@JaesungLeee JaesungLeee Awaiting requested review from JaesungLeee JaesungLeee is a code owner

Assignees

@hj1115hj hj1115hj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hj1115hj @ze-zeh @EvergreenTree97