Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 밈 생성 텍스트필드 구현 #245

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

evergreentree97
Copy link
Collaborator

작업 내역 (Required)

  • 아래 사진에 필요한 TextField와 TextArea 구현
  • Search 상단 탑바 텍스트필드는 윤형누나랑 얘기했을때, 별개로 얘기하여서 따로 만들어야함! (크기가 다름)

Review Point (Required)

  • 빼먹은 파라미터가 있는지?

Screenshot

image

Copy link
Collaborator

@hj1115hj hj1115hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Collaborator

@ze-zeh ze-zeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳잡굳잡!!

Comment on lines 35 to 36
trailingContent: @Composable () -> Unit = {},
onTextChanged: (String) -> Unit,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 파라미터들 순서가 뒤로가면 더 좋을거같네용

Comment on lines 88 to 89
trailingContent: @Composable () -> Unit = {},
onTextChanged: (String) -> Unit = {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도~!

onTextChanged: (String) -> Unit,
enabled: Boolean = true,
keyboardOptions: KeyboardOptions = KeyboardOptions.Default,
keyboardActions: KeyboardActions = KeyboardActions.Default,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactionSource도 혹여나 상태감지 생각해서 빼도 괜찮을 것 같은 느낌?

@evergreentree97 evergreentree97 merged commit 88d1ae5 into develop Sep 26, 2024
@evergreentree97 evergreentree97 deleted the feat/textfield branch September 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants