-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 밈 생성 텍스트필드 구현 #245
[Feat] 밈 생성 텍스트필드 구현 #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳잡굳잡!!
trailingContent: @Composable () -> Unit = {}, | ||
onTextChanged: (String) -> Unit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 파라미터들 순서가 뒤로가면 더 좋을거같네용
trailingContent: @Composable () -> Unit = {}, | ||
onTextChanged: (String) -> Unit = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도~!
onTextChanged: (String) -> Unit, | ||
enabled: Boolean = true, | ||
keyboardOptions: KeyboardOptions = KeyboardOptions.Default, | ||
keyboardActions: KeyboardActions = KeyboardActions.Default, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interactionSource도 혹여나 상태감지 생각해서 빼도 괜찮을 것 같은 느낌?
작업 내역 (Required)
Review Point (Required)
Screenshot