99 implement deploy chunk upload fct #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thomas-senechal
force-pushed
the
99-implement-deploy-chunk-upload-fct
branch
3 times, most recently
from
74bf010
to
3ce4da3
Compare
…k to list of ChunkPost
…d an empty delete command
…ve exec in uploadChunks
… and functional-test-cli jobs
thomas-senechal
force-pushed
the
99-implement-deploy-chunk-upload-fct
branch
from
7708c2e
to
5855a38
Compare
Ben-Rey
reviewed
Sep 25, 2024
Ben-Rey
reviewed
Sep 25, 2024
Ben-Rey
reviewed
Sep 25, 2024
Ben-Rey
reviewed
Sep 25, 2024
Ben-Rey
reviewed
Sep 25, 2024
|
|
||
| getBatches(): UploadBatch[] { | ||
| return this.batches | ||
| } |
There was a problem hiding this comment.
Just for information, you could do that
get batches(): UploadBatch[] {
return this._batches;
}
Ben-Rey
reviewed
Sep 25, 2024
Ben-Rey
reviewed
Sep 25, 2024
| BigInt(ownerKey.length), | ||
| BigInt(provider.address.length) | ||
| ) | ||
| const fileListCost = storageCostForEntry(1n, BigInt(U32.SIZE_BYTE)) |
There was a problem hiding this comment.
Just to keep in mind that we will need to update this when pr of sc will be merge
There was a problem hiding this comment.
Context, the PR in question is the one about immutability and deweb version: https://github.com/massalabs/DeWeb/pull/126/files#diff-3ebdaef67413baee44de673e3d6d885fe674d291758dbb9fb9857e27aa54e0f1R28
Ben-Rey
approved these changes
Sep 25, 2024
pivilartisant
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Add chunk functions and tests for devideIntoChunks function * Add jest * Add storage cost variables * Update massa-web3 * Fix entry cost in lib/utils/storage * Add ChunkPost class and toChunkPosts function to convert list of chunk to list of ChunkPost * Add batcher function to divide list of chunks into batches smaller than chunk size * Replace deploy and edit commands with a single upload command, and add an empty delete command * Add tests for ChunkPost and toChunkPosts functions * Add built sc files in .gitignore * Fix lint errors and error with subdirectories handling in prepareChunks * Fix a bug with base path in prepareChunks and add await for speculative exec in uploadChunks * Add ls command * Update eslint to v9 * Fix missnamed option in delete command * Add a function to calculate deployment cost * Add a basic uploadManager * Use listr2 to show upload progress * Remove useless logger from tasks ctx * Show batch and chunk information in prepareBatchesTask * Fix typo in deploySC task prompt * Add check for available funds before deploying the website * Add yaml keystore handling * Add functional test for CLI deployment with wallet handling * Fix upload command in cli functional test CI * Commented functional test cli for later * Remove useless totalChunks from ChunkPost * Fix lint errors * Add wallet files to gitignore * Fix build:sc script * Fix getChunkKey * Fix entry storage cost calculation * Update CLI to match new SC * Add getTotalChunkKey function * Add getFileFromAddress function * Remove unnecessary file listing from upload command * Add showFileCommand to CLI * Improve chunks and prestore handling * Update runs-on value in tests.yml to use ubuntu-22.04 for test-server and functional-test-cli jobs * Add sc build in cli functionnal test * Add .gitkeep in cli/src/lib/website/sc * Fix go cache path * Update massa web3 to fix crypto lib * Fix chunkPost tests * Add missing doc in tasks/prepareChunk.ts * Add test-cli workflow for CLI unit tests * Use massa-web3 PublicApiUrl instead of raw url for buildnet url --------- Co-authored-by: BenRey <br@massa.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.