Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configFile support in cli #131

Merged
merged 17 commits into from
Oct 4, 2024
Merged

Add configFile support in cli #131

merged 17 commits into from
Oct 4, 2024

Conversation

pivilartisant
Copy link
Collaborator

No description provided.

@pivilartisant pivilartisant linked an issue Sep 27, 2024 that may be closed by this pull request
Add signing w/ secret key using CLI #102
Closed
8 tasks
@pivilartisant pivilartisant marked this pull request as draft September 27, 2024 08:05
@pivilartisant pivilartisant linked an issue Sep 27, 2024 that may be closed by this pull request
Create config file for CLI #101
Closed
3 tasks
@pivilartisant
Copy link
Collaborator Author

also adressing this issue here: #102

@pivilartisant pivilartisant force-pushed the 102-add-signing-w-secret-key-using-cli branch 5 times, most recently from 63c1b35 to 00923e6 Compare September 27, 2024 11:13
@pivilartisant
Copy link
Collaborator Author

I believe we should add more test in CI for different keyPair initialization scenarios

@pivilartisant pivilartisant marked this pull request as ready for review September 27, 2024 11:23
@pivilartisant pivilartisant marked this pull request as draft October 2, 2024 07:35
@pivilartisant pivilartisant force-pushed the 102-add-signing-w-secret-key-using-cli branch from 00923e6 to f8b5182 Compare October 2, 2024 07:49
@pivilartisant pivilartisant changed the title Add basic configFile support in cli Add configFile support in cli Oct 2, 2024
@pivilartisant pivilartisant marked this pull request as ready for review October 2, 2024 10:15
thomas-senechal
thomas-senechal requested changes Oct 2, 2024
View reviewed changes
cli/src/commands/utils.ts Outdated Show resolved Hide resolved
cli/src/commands/utils.ts Outdated Show resolved Hide resolved
cli/src/commands/utils.ts Outdated Show resolved Hide resolved
cli/src/commands/utils.ts Outdated Show resolved Hide resolved
cli/src/commands/utils.ts Outdated Show resolved Hide resolved
cli/src/index.ts Outdated Show resolved Hide resolved
@pivilartisant pivilartisant force-pushed the 102-add-signing-w-secret-key-using-cli branch from 9a91084 to a4db824 Compare October 2, 2024 15:29
@pivilartisant pivilartisant force-pushed the 102-add-signing-w-secret-key-using-cli branch from a4db824 to a26597d Compare October 2, 2024 15:31
@pivilartisant pivilartisant requested review from thomas-senechal and removed request for thomas-senechal October 2, 2024 16:12
thomas-senechal
thomas-senechal requested changes Oct 3, 2024
View reviewed changes
cli/default_cli_config.json Outdated Show resolved Hide resolved
cli/src/commands/config.ts Outdated Show resolved Hide resolved
cli/src/commands/list.ts Outdated Show resolved Hide resolved
cli/src/commands/upload.ts Outdated Show resolved Hide resolved
cli/src/commands/upload.ts Outdated Show resolved Hide resolved
thomas-senechal
thomas-senechal reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to fix as CI isn't passing

cli/src/commands/config.ts Show resolved Hide resolved
@pivilartisant pivilartisant requested review from thomas-senechal and removed request for Ben-Rey October 4, 2024 09:03
@pivilartisant pivilartisant merged commit b7285dc into main Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-senechal thomas-senechal thomas-senechal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add signing w/ secret key using CLI Create config file for CLI
2 participants
@pivilartisant @thomas-senechal