fix: allows enable/disable of detections via config file#174
Open
rileydakota wants to merge 2 commits intomatanolabs:mainfrom
Open
fix: allows enable/disable of detections via config file#174rileydakota wants to merge 2 commits intomatanolabs:mainfrom
rileydakota wants to merge 2 commits intomatanolabs:mainfrom
Conversation
Contributor
Author
|
I am also willing to move this logic to the infra code and just have the decision made to package a detection or not via the CDK. Just wanted to open a PR to start the discussion 😁 |
Contributor
Author
|
@shaeqahmed @Samrose-Ahmed any chance we could kick off the CI job again, I am a bit confused on why the build failed |
Contributor
|
Hey @rileydakota, looks like you might need to rebase since I recently committed a change to fix the broken CI build error you are getting |
Contributor
Author
|
@shaeqahmed looks like that did the trick! Would love some feedback on this when you get time :). Totally happy to refactor this to live in the CDK portion of the app versus runtime if that makes more sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to throw this out there to start a discussion on the implementation. I tested with:
thoughts? Major thing IMO would be that it defaults to false if the key isn't specified, but I believe this is consistent with the docs.