Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #420

Closed
wants to merge 2 commits into from
Closed

add task solution #420

wants to merge 2 commits into from

Conversation

vneholiuk
Copy link

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

  • Make it possible to scroll the menu if it is higher than the viewport;
    exapmple:
.menu {
  overflow: auto; /* to scroll the menu if needed */
}
.menu__top {
  position: sticky; /* to keep cross always visible */
  top: 0;
  z-index: 1;
  background-color: #e5e5e5;
}

Screenshot from 2024-03-05 15-11-30

  • check color of header title
    design:
    Screenshot from 2024-03-05 15-15-29

actual:
Screenshot from 2024-03-05 15-15-41

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, redeploy your solution and check demo_link before review
image

@vneholiuk vneholiuk closed this by deleting the head repository Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants