Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #426

wants to merge 3 commits into from

Conversation

valentin19939
Copy link

vadiimvooo
vadiimvooo suggested changes Mar 29, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just a few changes:

  1. There is some problems with fonts, please check mockup
    image
  2. Add transition for hover effect for all buttons and interactive elements.

vadiimvooo
vadiimvooo suggested changes Mar 29, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no changes with last review. Please feel free to ask for help in chat if you need it.

vadiimvooo
vadiimvooo suggested changes Mar 29, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the video where you can see that transition effects were not applied. As I mentioned before don't hesitate to ask for help in fe_chat.

@valentin19939
Copy link
Author

Here is the video where you can see that transition effects were not applied. As I mentioned before don't hesitate to ask for help in fe_chat.

який саме перехід ? при відкриванні меню?

vadiimvooo
vadiimvooo approved these changes Mar 29, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now transitions on buttons works perfectly. Well done!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadiimvooo vadiimvooo vadiimvooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin19939 @vadiimvooo