Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #431

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

solution #431

wants to merge 7 commits into from

Conversation

HannaMatviienko
Copy link

SanyaBratashchuk
SanyaBratashchuk suggested changes Apr 24, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. apply cursor: pointer for all interactable elements
  2. add paddings
    image
  3. should be link for google maps
    image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Apr 25, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. You need to remove scroll when the burger menu is open
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Apr 25, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-04-25 at 14 54 30
The menu should be scrollable in landscape mode
Screenshot 2024-04-25 at 14 52 00
Screenshot 2024-04-25 at 14 52 06

SanyaBratashchuk
SanyaBratashchuk suggested changes Apr 25, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. menu should have scroll when there is no enough height for content
    image

l4st1m0za
l4st1m0za suggested changes Apr 28, 2024
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Liks like this should open separate tab
image
  1. This button should not close the menu
image
  1. Place this photo so it's not cropped
image
  1. All the animations should be smooth

l4st1m0za
l4st1m0za approved these changes Apr 30, 2024
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Hover here should be smooth
image

And here also

image

In conslusion, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l4st1m0za l4st1m0za l4st1m0za approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HannaMatviienko @volodymyr-soltys97 @l4st1m0za @SanyaBratashchuk @anastasiiavorobiova