Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #435

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add solution #435

wants to merge 6 commits into from

Conversation

Alenalenk
Copy link

SanyaBratashchuk
SanyaBratashchuk suggested changes May 7, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Check icon color with design
    image
  2. apply cursor: pointer for all interactable elements

maxim2310
maxim2310 suggested changes May 7, 2024
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple tiny things needs to be fixed before approval)

  1. check color of logo
  2. apply cursor: pointer for all interactable elements
    image
  3. would be nice to make main block 100vh
    image

@Alenalenk Alenalenk requested a review from maxim2310 May 8, 2024 06:25
volodymyr-soltys97
volodymyr-soltys97 approved these changes May 8, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@maxim2310 maxim2310 Awaiting requested review from maxim2310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenalenk @volodymyr-soltys97 @maxim2310 @SanyaBratashchuk