Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

museum2 #461

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

museum2 #461

wants to merge 4 commits into from

Conversation

Alex-redman
Copy link

SanyaBratashchuk
SanyaBratashchuk suggested changes Oct 4, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add favicon
  2. add meaningful page title
  3. disable scroll when menu is open
  4. form should submit on підписатись button click

@TarasHoliuk
Copy link

Great job!

A few more things should be improved:

  1. Scroll should be smooth (when you click any anchor link)
  2. You forgot to make it link as well 🙂 :

image

  1. Would be nice to make the menu disappear smoothly (not only appear)

TarasHoliuk
TarasHoliuk suggested changes Oct 6, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! GJ 👍 I observed a few things that should be improved (the main is smooth scroll)

anastasiiavorobiova
anastasiiavorobiova approved these changes Oct 7, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex-redman @TarasHoliuk @SanyaBratashchuk @anastasiiavorobiova