Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate order hw implementation #769

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ValentynSharshon
Copy link

No description provided.

Copy link

@SkillfulDev SkillfulDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines 70 to 71
String email = "testemail@email.com";
String password = "testpassword";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it constants

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Comment on lines 10 to 11
<property name="connection.username">root</property>
<property name="connection.password">0000</property>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<property name="connection.username">root</property>
<property name="connection.password">0000</property>
<property name="connection.username"></property>
<property name="connection.password"></property>

Don't pass your credentials

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link

@SkillfulDev SkillfulDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Copy link

@andrii-hoienko andrii-hoienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Comment on lines 20 to 25
@OneToMany
private List<Ticket> tickets;

private LocalDateTime orderDateTime;

@ManyToOne

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify joinColumn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants