Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OrderService #771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oksana-miazina
Copy link

No description provided.

Copy link

@karma-o karma-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Left a small suggestion

Comment on lines +71 to +82
try {
authenticationService.register(USER_EMAIL, USER_PASSWORD);
} catch (RegistrationException e) {
throw new RuntimeException("Can't register new user with email: " + USER_EMAIL, e);
}

User user = null;
try {
user = authenticationService.login(USER_EMAIL, USER_PASSWORD);
} catch (AuthenticationException e) {
throw new RuntimeException("Can't login with email: " + USER_EMAIL, e);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in main we can rethrow exception to the method signature instead of try/catch but that is up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants