add task solution #2639
Open
add task solution #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Jul 31, 2023
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| let newString = ''; | ||
| let sepanullator = separator; |
src/arrayMethodJoin.js
Outdated
Comment on lines
11
to
13
| if (separator === null) { | ||
| sepanullator = 'null'; | ||
| } |
There was a problem hiding this comment.
separator won't ever be null - we have defaultet it to ','
There was a problem hiding this comment.
Ah was sure i need this for this test: test
source = [0, 1, 2, 3];
(Should work with null, () => {
expect(source.join2(null))
.toBe('0null1null2null3');
});
src/arrayMethodJoin.js
Outdated
Comment on lines
16
to
32
| if ( | ||
| (this[i] === null || this[i] === undefined) | ||
| && i === this.length - 1) { | ||
| break; | ||
| } | ||
|
|
||
| if (this[i] === null || this[i] === undefined) { | ||
| newString += sepanullator; | ||
| continue; | ||
| } | ||
|
|
||
| if (i === this.length - 1) { | ||
| newString += this[i]; | ||
| break; | ||
| } | ||
|
|
||
| newString += this[i] + sepanullator; |
There was a problem hiding this comment.
It is way easier to check for cases when we want to apply logic, instead of getting rid of everyone single other one 🔽
Suggested change
| if ( | |
| (this[i] === null || this[i] === undefined) | |
| && i === this.length - 1) { | |
| break; | |
| } | |
| if (this[i] === null || this[i] === undefined) { | |
| newString += sepanullator; | |
| continue; | |
| } | |
| if (i === this.length - 1) { | |
| newString += this[i]; | |
| break; | |
| } | |
| newString += this[i] + sepanullator; | |
| if (this[i] !== null && this[i] !== undefined) { | |
| newString += String(this[i]) | |
| } | |
| if (i < this.length - 1) { | |
| newString += separator | |
| } |
choeqq
suggested changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.