Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add join solution #2648

Closed
wants to merge 1 commit into from
Closed

Add join solution #2648

wants to merge 1 commit into from

Conversation

WaveOfDandelions
Copy link

No description provided.

choeqq
choeqq approved these changes Jul 31, 2023
View reviewed changes
Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, please name your variables little bit more descriptively 🚀

src/arrayMethodJoin.js
[].__proto__.join2 = function(separator) {
// write code here
[].__proto__.join2 = function(separator = ',') {
let string = '';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do better on that name 😄

@WaveOfDandelions WaveOfDandelions closed this by deleting the head repository Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choeqq choeqq choeqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaveOfDandelions @choeqq