feat: add task solution #2674
Open
feat: add task solution #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
suggested changes
Aug 7, 2023
src/arrayMethodJoin.js
Outdated
| [].__proto__.join2 = function(separator) { | ||
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| const currentArray = this; |
There was a problem hiding this comment.
I guess we don't really need to create this variable
src/arrayMethodJoin.js
Outdated
Comment on lines
13
to
15
| if (!(currentArray instanceof Array)) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
On line 10 you create this method as a method of Array. So this method can be called only on array
src/arrayMethodJoin.js
Outdated
| return ''; | ||
| } | ||
|
|
||
| const INDEX_OF_LAST_ELEMENT = currentArray.length - 1; |
There was a problem hiding this comment.
If you want to create variable for this, name it in camelCase
tiserett
approved these changes
Aug 8, 2023
|
|
||
| let concatedString = ''; | ||
|
|
||
| for (let curIndex = 0; curIndex < this.length; curIndex++) { |
There was a problem hiding this comment.
I feel like curIndex is a redundant name, because everyone knows that 'i' is current index ;)
| @@ -3,9 +3,28 @@ | |||
| /** | |||
| * Implement method join | |||
| */ | |||
|
|
|||
| const isNotIgnoredEl = (el) => ![null, undefined].includes(el); | |||
There was a problem hiding this comment.
let's check if element isIgnored, and then set value to opposite, in place where we call it, I guess that's gonna be more correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.