initial commit #2678
initial commit #2678
Conversation
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| let stringAfterJoin = ''; | ||
| const copyArray = this.slice(); |
There was a problem hiding this comment.
- [CODE STYLE] - avoid creating needless copies of arrays, you can iterate existing array
src/arrayMethodJoin.js
Outdated
| if (finallySeparator === null) { | ||
| finallySeparator = 'null'; | ||
| } |
There was a problem hiding this comment.
little advice for you
console.log(String(null)) // 'null'
console.log(typeof String(null)) // string
const test = null
console.log(`${test}`) // 'null'
console.log("result: " + test) // result: null
src/arrayMethodJoin.js
Outdated
| } | ||
|
|
||
| for (let i = 0; i < copyArray.length; i++) { | ||
| if (copyArray[i] === undefined || copyArray[i] === null) { |
There was a problem hiding this comment.
try to invert this condition i think if we go in this direction it might help us to write shorter code
| if (copyArray[i] === undefined || copyArray[i] === null) { | |
| if (copyArray[i] != null) { |
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| let stringAfterJoin = ''; | ||
| const finallySeparator = separator; |
src/arrayMethodJoin.js
Outdated
| if (this.length === 0) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
Do we really need this?
If length === 0 we will skip the loop and return stringAfterJoin which is equal to ''
src/arrayMethodJoin.js
Outdated
| } | ||
|
|
||
| for (let i = 0; i < this.length; i++) { | ||
| if (this[i] !== null && this[i] !== undefined) { |
There was a problem hiding this comment.
You are using this[i] 3 times. Create variable for this value
src/arrayMethodJoin.js
Outdated
| stringAfterJoin += this[i]; | ||
| } | ||
|
|
||
| if (i < this.length - 1 && finallySeparator !== undefined) { |
There was a problem hiding this comment.
You set a default value for the separator, so it will never be equal to undefined
| stringAfterJoin += element; | ||
| } | ||
|
|
||
| if (i < this.length - 1) { |
There was a problem hiding this comment.
I suggest putting this.length in a variable, since we already use it twice, but I guess it's optional
No description provided.