solution #2682
solution #2682
Conversation
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| const currentArrayLength = this.length; | ||
| const joinSeparator = separator + ''; |
There was a problem hiding this comment.
I propose to use a more readable string transform for it.
| const joinSeparator = separator + ''; | |
| const joinSeparator = String(separator); |
src/arrayMethodJoin.js
Outdated
| this.forEach((item, index) => { | ||
| /* const stringCharacter = item ?? '' is the best choice, | ||
| but I couldn`t disable eslint for the nullish operator */ | ||
| const stringCharacter = item === null || item === undefined |
There was a problem hiding this comment.
You can make it shorter using ==
console.log(undefined == null) // true
console.log(null == null) // true
console.log(false == null) // falseThere was a problem hiding this comment.
using == is very dangerous for our karma)
src/arrayMethodJoin.js
Outdated
| currentArrayLength - 1 === index | ||
| ? resultingString += stringCharacter | ||
| : resultingString += stringCharacter + joinSeparator; |
There was a problem hiding this comment.
I think better to use if statement here because it makes our code more readable.
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| const currentArrayLength = this.length; | ||
| const joinSeparator = String(separator); |
There was a problem hiding this comment.
Do we really need this?
I guess result will be the same with and without String()
src/arrayMethodJoin.js
Outdated
| if (!currentArrayLength) { | ||
| return resultingString; | ||
| } |
There was a problem hiding this comment.
Do we really need this?
If length === 0 we will skip forEach and also return resultingString
src/arrayMethodJoin.js
Outdated
| if (currentArrayLength - 1 === index) { | ||
| resultingString += stringCharacter; | ||
| } else { | ||
| resultingString += stringCharacter + joinSeparator; | ||
| } |
There was a problem hiding this comment.
Do we really need else here? Maybe we can simplify this and use only if?
P.S. We do the same part of logic in if and in else block
src/arrayMethodJoin.js
Outdated
| const joinSeparator = String(separator); | ||
| let resultingString = ''; | ||
|
|
||
| this.forEach((item, index) => { |
There was a problem hiding this comment.
Using Array methods is prohibited in this task. Use loops, index access, and array length if needed.
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| const currentArrayLength = this.length; | ||
| const joinSeparator = String(separator); |
| resultingString += stringCharacter; | ||
| resultingString += separator; |
No description provided.