Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2687

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/arrayMethodJoin.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,26 @@
* Implement method join
*/
function applyCustomJoin() {
[].__proto__.join2 = function(separator) {
// write code here
[].__proto__.join2 = function(separator = ',') {
let resultString = '';

if (this.length === 0) {
return '';
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this check if you have this one:


    if (!this[this.length - 1]) {
      return resultString;
    }
    


for (let i = 0; i < this.length - 1; i++) {
if (this[i] !== undefined && this[i] !== null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using this[i] 3 times. Create variable for this value

resultString += this[i];
}

resultString += separator;
}

if (!this[this.length - 1]) {
return resultString;
}

return resultString + this[this.length - 1];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acn we use lastElement here?

};
}

Expand Down
Loading