Develop #2715
Open
Develop #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Aug 8, 2023
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| const arrCopy = [ ...this ]; | ||
| let ConcatenatedStr = ''; |
There was a problem hiding this comment.
variables name should be in a camelCase
src/arrayMethodJoin.js
Outdated
| const arrCopy = [ ...this ]; | ||
| let ConcatenatedStr = ''; | ||
|
|
||
| if (arrCopy.length === 0) { |
There was a problem hiding this comment.
Suggested change
| if (arrCopy.length === 0) { | |
| if (!arrCopy.length) { |
etojeDenys
suggested changes
Aug 10, 2023
src/arrayMethodJoin.js
Outdated
Comment on lines
8
to
33
| const arrCopy = [ ...this ]; | ||
| let concatenatedStr = ''; | ||
|
|
||
| if (!arrCopy.length) { | ||
| return ''; | ||
| } | ||
|
|
||
| for (let i = 0; i < arrCopy.length; i++) { | ||
| if (arrCopy[i] === undefined || arrCopy[i] === null) { | ||
| arrCopy[i] = ''; | ||
| } | ||
| } | ||
|
|
||
| for (let i = 0; i < arrCopy.length - 1; i++) { | ||
| arrCopy[i] += separator; | ||
|
|
||
| if (separator === null) { | ||
| arrCopy[i] += 'null'; | ||
| } | ||
|
|
||
| concatenatedStr += arrCopy[i]; | ||
| } | ||
|
|
||
| concatenatedStr += arrCopy[arrCopy.length - 1]; | ||
|
|
||
| return concatenatedStr; |
There was a problem hiding this comment.
we can simplify this logic using only one loop and without copy the array
think about how to implement it and feel free to ask in the chat
loralevitska
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.