Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2653

wants to merge 1 commit into from

Conversation

LabPetro
Copy link

@LabPetro LabPetro commented Oct 3, 2023

No description provided.

anastasiia-tilikina
anastasiia-tilikina approved these changes Oct 3, 2023
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Approved.

But havea a look at my comment, you can simplify your if condition here. Consider using this in the future

src/inverseRobot.js
for (const key in robot) {
const robotValue = robot[key];

if (tobor[robotValue] !== undefined) {
Copy link

@anastasiia-tilikina anastasiia-tilikina Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (tobor[robotValue] !== undefined) {
if (tobor[robotValue]) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiia-tilikina anastasiia-tilikina anastasiia-tilikina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LabPetro @anastasiia-tilikina