Solution #2284
Open
Solution #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrzejPec
suggested changes
Jul 25, 2023
src/transformState.js
Outdated
| }; | ||
|
|
||
| if (actions[i][key] === 'removeProperties') { | ||
| for (const key1 in actions[i]['keysToRemove']) { |
There was a problem hiding this comment.
according to the checklist: 1. [CODE STYLE]: don't use for in loop for iterating over array
src/transformState.js
Outdated
| function transformState(state, actions) { | ||
| // write code here | ||
| for (let i = 0; i < actions.length; i++) { | ||
| for (const key in actions[i]) { |
There was a problem hiding this comment.
according to checklist 5. [CODE STYLE]: Nested loops === EVIL.
Avoid evil ;)
src/transformState.js
Outdated
| // write code here | ||
| for (let i = 0; i < actions.length; i++) { | ||
| for (const key in actions[i]) { | ||
| if (actions[i][key] === 'addProperties') { |
There was a problem hiding this comment.
according to the checklist: 2. [CODE STYLE]: Use switch statement if you have limited amount of conditions.
AndrzejPec
reviewed
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.