Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2604

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #2604

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db1e125
Sulution
Reject-4444 Jul 25, 2023
0742ebb
solution
Reject-4444 Jul 27, 2023
c745b46
sort out last solution
Reject-4444 Jul 28, 2023
0827ab5
sort out last solution
Reject-4444 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/transformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,23 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
switch (true) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to come up with better condition than just leaving true
I'll give you a hint, in each case you compare action.type to something, why would you do that if whole idea of switch is to compare condition to case

case action.type === 'addProperties':
Object.assign(state, action.extraData);
break;

case action.type === 'removeProperties':
for (const keys of action.keysToRemove) {
delete state[keys];
};
break;

default:
Object.keys(state).forEach(n => delete state[n]);
break;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be another case, not default one

}
}
}

module.exports = transformState;
Loading