Solution #2605
Open
Solution #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Jul 26, 2023
| for (const action of actions) { | ||
| switch (action.type) { | ||
| case 'addProperties': | ||
| Object.assign(state, action.extraData); |
There was a problem hiding this comment.
this can also be achieved using spread operator which is more common nowadays
There was a problem hiding this comment.
I'm not sure about spread operator in this case. I tried, but tests were failed. So, I left the option with Object.assign().
There was a problem hiding this comment.
That is correct solution in this case, spread operator is great on it's own, but the task forces us to think differently
src/transformState.js
Outdated
Comment on lines
7
to
29
| function transformState(state, actions) { | ||
| // write code here | ||
| for (const action of actions) { | ||
| switch (action.type) { | ||
| case 'addProperties': | ||
| Object.assign(state, action.extraData); | ||
| break; | ||
| case 'removeProperties': | ||
| for (const key of action.keysToRemove) { | ||
| if (state.hasOwnProperty(key)) { | ||
| delete state[key]; | ||
| } | ||
| } | ||
| break; | ||
| case 'clear': | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
| break; | ||
| default: | ||
| throw new Error(`Unknown action type: ${action.type}`); | ||
| } | ||
| } | ||
| } |
| switch (action.type) { | ||
| case 'addProperties': | ||
| Object.assign(state, action.extraData); | ||
| break; |
There was a problem hiding this comment.
consider adding empty line after each break statement
JoyCoffeeAddict
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.