Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #2611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #2611

wants to merge 1 commit into from

Conversation

SviatoslavVasyletskyi
Copy link

No description provided.

domalewski
domalewski suggested changes Jul 26, 2023
View reviewed changes
Copy link

@domalewski domalewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great just minor changes and you are good to go
for readability add some spaces between case's and so on
default should return error (check point 4 on checklist)
function should return state

choeqq
choeqq approved these changes Jul 27, 2023
View reviewed changes
src/transformState.js
case 'addProperties':
if (action.extraData && typeof action.extraData === 'object') {
for (const [key, value] of Object.entries(action.extraData)) {
state[key] = value;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.assign() would useful there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domalewski domalewski domalewski requested changes

@choeqq choeqq choeqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SviatoslavVasyletskyi @choeqq @domalewski