add task solution #2617
Open
add task solution #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meg-Sowka
suggested changes
Jul 26, 2023
choeqq
suggested changes
Jul 27, 2023
src/transformState.js
Outdated
Comment on lines
11
to
13
| const ADD_PROPERTIES = order.type === 'addProperties'; | ||
| const REMOVE_PROPERTIES = order.type === 'removeProperties'; | ||
| const CLEAR_ALL = order.type === 'clear'; |
There was a problem hiding this comment.
those should be constants outside of function - not depending on order.type
src/transformState.js
Outdated
Comment on lines
15
to
35
| if (ADD_PROPERTIES) { | ||
| Object.assign(state, order.extraData); | ||
| stateHistory.push(Object.assign({}, state)); | ||
| } | ||
|
|
||
| if (REMOVE_PROPERTIES) { | ||
| for (const remove of order.keysToRemove) { | ||
| delete state[remove]; | ||
| } | ||
|
|
||
| stateHistory.push(Object.assign({}, state)); | ||
| } | ||
|
|
||
| if (CLEAR_ALL) { | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
|
|
||
| stateHistory.push(Object.assign({}, state)); | ||
| } | ||
| } |
There was a problem hiding this comment.
according to checklist you should use switch statement
| @@ -5,7 +5,36 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| const stateHistory = []; | |||
There was a problem hiding this comment.
you weren't prompted to track state history, but it's good idea 😄
choeqq
suggested changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.