Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #2634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maksym-mishchanchuk
Copy link

No description provided.

Copy link

@Vannnkof Vannnkof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

but one moment in checklist
5. [CODE STYLE]: Nested loops === EVIL

Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@@ -5,7 +5,40 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const key of actions) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

const add = (state, obj) => {
for (const key in obj) {
state[key] = obj[key];
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little easier to add extraData using Object.assign:

 Object.assign(state, obj.extraData);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants