Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #2642

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #2642

wants to merge 3 commits into from

Conversation

ivannaromanovych
Copy link

No description provided.

davinnchii
davinnchii approved these changes Jul 31, 2023
View reviewed changes
Copy link

@davinnchii davinnchii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general everything is fine, but I'd prefer to use .forEach method instead of common for-loop

roman-mirzoian
roman-mirzoian suggested changes Aug 2, 2023
View reviewed changes
Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there is quite a bit of work to be done.

src/transformState.js Outdated
});
break;
default:
break;
Copy link

@roman-mirzoian roman-mirzoian Aug 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
For this task, you can return some message that something went wrong.

qoa11a
qoa11a approved these changes Aug 2, 2023
View reviewed changes
Copy link

@qoa11a qoa11a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qoa11a qoa11a qoa11a approved these changes

@davinnchii davinnchii davinnchii approved these changes

@roman-mirzoian roman-mirzoian Awaiting requested review from roman-mirzoian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivannaromanovych @roman-mirzoian @qoa11a @davinnchii