Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #2647

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #2647

wants to merge 4 commits into from

Conversation

Patryk-Buczkowski
Copy link

No description provided.

DorotaLeniecDev
DorotaLeniecDev suggested changes Aug 1, 2023
View reviewed changes
Copy link

@DorotaLeniecDev DorotaLeniecDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist Use switch statement if you have limited amount of conditions.

Refactor using switch

DorotaLeniecDev
DorotaLeniecDev suggested changes Aug 2, 2023
View reviewed changes
Copy link

@DorotaLeniecDev DorotaLeniecDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, one more thing, add default case to your switch

DorotaLeniecDev
DorotaLeniecDev approved these changes Aug 3, 2023
View reviewed changes
Copy link

@DorotaLeniecDev DorotaLeniecDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorotaLeniecDev DorotaLeniecDev DorotaLeniecDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patryk-Buczkowski @DorotaLeniecDev