Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2652

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/transformState.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,29 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const obj of actions) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed.

switch (obj.type) {
case 'addProperties':
Object.assign(state, obj.extraData);

break;

case 'removeProperties':
for (const removeKey of obj.keysToRemove) {
delete state[removeKey];
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Better use forEach()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed.


break;

case 'clear':
for (const key in state) {
delete state[key];
}
break;

default : return null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to return an error or a message that something went wrong.

}
}
}

module.exports = transformState;
Loading