Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #2658

Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/transformState.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,30 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
switch (action.type) {
case 'addProperties':
Object.assign(state, action.extraData);
break;

case 'removeProperties':
for (const key of action.keysToRemove) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. [Checklist] [CODE STYLE]: Nested loops === EVIL

it would be better not to use nested loops

delete state[key];
}
break;

case 'clear':
for (const property in state) {
delete state[property];
}
break;

default:
throw new Error('sorry)))');
}
}

return state;
}

module.exports = transformState;
Loading