Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #2659

wants to merge 2 commits into from

Conversation

irahos
Copy link

@irahos irahos commented Aug 1, 2023

No description provided.

break;

default:
throw Error('Invalid input.');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check correct error declaration


case 'removeProperties':
action.keysToRemove.forEach((key) => {
if (state.hasOwnProperty(key)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there is a need to check this condition - if (state.hasOwnProperty(key))

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants