add task solution #2663
Open
add task solution #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihorid
approved these changes
Aug 2, 2023
dffUqp
suggested changes
Aug 3, 2023
src/transformState.js
Outdated
Comment on lines
11
to
13
| for (const key in actions[i].extraData) { | ||
| state[key] = actions[i].extraData[key]; | ||
| } |
There was a problem hiding this comment.
we can make it easier by using Object.assign
src/transformState.js
Outdated
| @@ -5,7 +5,29 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| } | |||
| for (let i = 0; i < actions.length; i++) { | |||
Comment on lines
+23
to
+25
| for (const key in state) { | ||
| delete state[key]; | ||
| } |
There was a problem hiding this comment.
we clear all values from our object so can we just assign new empty object to avoid additional loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.