Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/transformState.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,25 @@
* @param {Object[]} actions
*/
function transformState(state, actions) {
// write code here
for (const obj of actions) {
if (obj.type === 'addProperties') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use destructuring for obj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use switch here will be better

Object.assign(state, obj.extraData);
}

if (obj.type === 'removeProperties') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this magic words to variable and use it everywhere

for (const key of obj.keysToRemove) {
delete state[key];
}
}

if (obj.type === 'clear') {
for (const prop in state) {
delete state[prop];
}
}
}

return state;
}

module.exports = transformState;
Loading